search

ros2 / geometry2

A set of ROS packages for keeping track of coordinate transforms.
BSD 3-Clause "New" or "Revised" License
113 stars 193 forks source link

Suppress spam from calling canTransform (backport #529) #615

Closed mergify[bot] closed 11 months ago

mergify[bot] commented 12 months ago

This is an automatic backport of pull request #529 done by Mergify.

Mergify commands and options
More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport ` will backport this PR on `` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com
clalancette commented 12 months ago

CI:

clalancette commented 12 months ago

After thinking about this more, I'm not entirely convinced we want to do this in Humble. While it does suppress the spam, it also substantially changes the messages being output by Humble. While that isn't expressly disallowed by our API/ABI policy, I do think it will be a surprise for users. So possibly we shouldn't do this in Humble, I'm not sure. @ahcorde thoughts here?

clalancette commented 11 months ago

After discussing this at the Waffle meeting, we decided that this change in behavior was OK. I'll go ahead and merge this, but @ahcorde if you have another opinion please feel free to leave it here.