search

ros2 / geometry2

A set of ROS packages for keeping track of coordinate transforms.
BSD 3-Clause "New" or "Revised" License
110 stars 193 forks source link

Adding NodeInterfaces to Buffer #656

Closed CursedRock17 closed 3 months ago

CursedRock17 commented 3 months ago

Resolves #580 by adding node_interfaces support to the constructor of tf2_ros::Buffer. Currently, this is still a work in progress to resolve the test failures. Similar to PR #576

CursedRock17 commented 3 months ago

colcon build and colcon test both run fine locally, is there a reason the CI is failing with such a weird error on here? Also, is it better to add another class constructor for Buffer that takes in the node_interfaces and calls create_service as the only call, or can we stay simple with the basic universal constructor?

ahcorde commented 3 months ago
ahcorde commented 3 months ago
ahcorde commented 3 months ago
ahcorde commented 3 months ago
methylDragon commented 1 week ago

Just a quick PSA to use NodeInterfaces (no expected/obligated actionable, more a request for help if anyone stumbles across this). I understand using the template approach helps prevent rippling out changes to any dependents of buffer.