search

ros2 / geometry2

A set of ROS packages for keeping track of coordinate transforms.
BSD 3-Clause "New" or "Revised" License
110 stars 193 forks source link

Restoring tf2_eigen Tests #670

Open CursedRock17 opened 3 months ago

CursedRock17 commented 3 months ago

This pull request is meant to solve this TODO in which convert needed to be added to complete the tests. The convert function was added in PR #167, the test should pass.

ahcorde commented 2 months ago
clalancette commented 2 months ago

@CursedRock17 Oof, unfortunately MSVC thinks that we have an ambiguous overload here. Can you take a look?

CursedRock17 commented 2 months ago

Sorry for the delay, so it looks like that ambigous functions call has been documented before in Pull Request #434. That solution continues to work even with clang, which was the main issues that we were having due to adl in other compilers. But we could also enable the permissive flag in the tf2_eigen CMakeLists.txt to prevent

forc[ing] everyone using MSVC to use the /permissive- flag

Either way I don't think we're getting around this because two phase lookup hasn't been diminished from MSVC and ADL will be the default on other compilers.