search

ros2 / launch

Tools for launching multiple processes and for writing tests involving multiple processes.
Apache License 2.0
126 stars 142 forks source link

Feature request: make timeout from launch_testing's process_start configurable #519

Closed MarcoLm993 closed 9 months ago

MarcoLm993 commented 3 years ago

Feature request

Feature description

Right now launch_tests wait only 15 seconds from the time the last process starts and the ReadyToTest action gets called. This value is hard-coded in launch_testing and can be found here. Even though most times this timeout is large enough, there might be some larger systems that take longer to get ready before the actual test is ready to be executed. In those cases the whole test will fail saying Timed out waiting for processes to start up.

It would be nice to have the possibility to configure the timeout from the command line, in order to set a larger one in case it is necessary.

hidmic commented 3 years ago

I fully agree @MarcoLm993. Would you be willing to contribute a patch?

marekmlk commented 9 months ago

Already implemented in #625 for rolling.

MarcoLm993 commented 9 months ago

Then I guess this issue can be closed :)