search

ros2 / launch

Tools for launching multiple processes and for writing tests involving multiple processes.
Apache License 2.0
126 stars 142 forks source link

Declare frontend group dependency & use explicit dependencies in launch_testing #520

Closed christophebedard closed 2 years ago

christophebedard commented 3 years ago

Part of https://github.com/ros2/launch_ros/issues/255

As suggested/discussed under https://github.com/ros2/launch/pull/516#issuecomment-880342455, this declares a group dependency for the launch frontends and declares explicit dependencies on launch_xml and launch_yaml for launch_testing.

Using both a group dependency and hard/explicit dependencies allows this to work fine with binaries (with bloom) and also allows us to include any future launch frontend (or any user's custom frontend) in source builds. This is similar to how rcl depends on both the rcl_logging_packages group and the default logging implementation explicitly.

Signed-off-by: Christophe Bedard bedard.christophe@gmail.com

christophebedard commented 2 years ago

@wjwwood I think this can be merged. This PR was tested alongside https://github.com/ros2/launch_ros/pull/256, see https://github.com/ros2/launch_ros/pull/256#issuecomment-966667695