Extend PythonExpression substitution to simplify the notation

ros2 / launch

Tools for launching multiple processes and for writing tests involving multiple processes.

Apache License 2.0

124 stars 139 forks source link

Extend PythonExpression substitution to simplify the notation #600

Closed kenji-miyake closed 2 years ago

kenji-miyake commented 2 years ago

Related to #469, I supported the notation of $(eval $(var value) == 'abc'). I'm not sure whether I should support $(eval value == 'abc') as well, but I guess it's a bit difficult because the current system seems to automatically drop ''.

I'll send this Draft PR in order to get reviews from maintainers.

kenji-miyake commented 2 years ago

I extended TextSubstitution and the parser in f5c41b245697b3f4e5a55b631eacc92a18688bdb to support $(eval value == 'abc'), but I guess it's not allowed...

kenji-miyake commented 2 years ago

@ivanpauno Hello, would you kindly review this, please? :pray:

kenji-miyake commented 2 years ago

I believe I can close this thanks to https://github.com/ros2/launch/pull/649.