search

ros2 / launch

Tools for launching multiple processes and for writing tests involving multiple processes.
Apache License 2.0
126 stars 144 forks source link

Switch to using a comprehension for process_names. #614

Closed clalancette closed 2 years ago

clalancette commented 2 years ago

Newer versions of flake8-comprehenstion complain about this usage, and the new code should be backwards compatible and faster to boot.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

clalancette commented 2 years ago

CI:

Blast545 commented 2 years ago

This will probably require a backport to Foxy and Galactic, see: https://ci.ros2.org/job/nightly_linux_foxy_coverage/

clalancette commented 2 years ago

@Mergifyio backport humble galactic foxy

mergify[bot] commented 2 years ago

backport humble galactic foxy

✅ Backports have been created

* [#615 Switch to using a comprehension for process_names. (backport #614)](https://github.com/ros2/launch/pull/615) has been created for branch `humble` * [#616 Switch to using a comprehension for process_names. (backport #614)](https://github.com/ros2/launch/pull/616) has been created for branch `galactic` * [#617 Switch to using a comprehension for process_names. (backport #614)](https://github.com/ros2/launch/pull/617) has been created for branch `foxy`