search

ros2 / launch

Tools for launching multiple processes and for writing tests involving multiple processes.
Apache License 2.0
126 stars 144 forks source link

Addresses issue #588, allowing dict for 'output' (backport #640) #647

Closed mergify[bot] closed 2 years ago

mergify[bot] commented 2 years ago

This is an automatic backport of pull request #640 done by Mergify.

Mergify commands and options
More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport ` will backport this PR on `` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com
adityapande-1995 commented 2 years ago

CI :

m-elwin commented 2 years ago

I'm not very familiar with the ROS CI stuff, but the CI console output is making it look like the merge is causing conflicts in the "__ci_default" branch of this repo when the vcs command is being run. I'm not sure how this works but when I merge locally into the humble branch it's a fast forward merge

clalancette commented 2 years ago

The CI run was using the wrong ros2.repos URL, it needs to use a humble one. I've kicked it off again with an appropriate ros2.repos:

adityapande-1995 commented 2 years ago

Thanks @clalancette for the correction !