search

ros2 / launch

Tools for launching multiple processes and for writing tests involving multiple processes.
Apache License 2.0
124 stars 139 forks source link

Request for Release in Humble and Rolling #650

Closed ijnek closed 2 years ago

ijnek commented 2 years ago

With #640 and #647 (backport PR) merged, may I request the maintainers to make a release for Rolling and Humble please? It fixes some unintended breakages caused by #588, and I believe it affects a fair number of projects. Thanks!

clalancette commented 2 years ago

This is done in https://github.com/ros/rosdistro/pull/34520 (and I'll be merging it soon), so closing this out.

ijnek commented 2 years ago

Thank you @clalancette !

stefanscherzinger commented 1 year ago

May I ask if this gets released for Humble as well? The respective PR is not yet listed in the rosdistro's PRs and the launch version still seems to be 1.0.2-1.

FranekStark commented 1 year ago

@stefanscherzinger I agree on that. The bug is really annoying and should be fixed in humble asap.

stefanscherzinger commented 1 year ago

@FranekStark

In the meantime, I'm using some practical hack for my launch files:

import os
if os.environ['ROS_DISTRO'] == 'humble':
    output = "both"
else:  # foxy, galactic
    output = {"stdout": "screen", "stderr": "screen"}

and then

    my_node = Node(
        package="some_package",
        executable="some_executable",
        output=output
        # ...
    )