search

ros2 / launch

Tools for launching multiple processes and for writing tests involving multiple processes.
Apache License 2.0
124 stars 139 forks source link

Expose sigterm_timeout and sigkill_timeout to xml frontend #667

Closed adityapande-1995 closed 1 year ago

adityapande-1995 commented 1 year ago

This PR exposes sigkill_timeout and sigterm_timeout arguments to xml frontends. Added a simple test for parsing using xml.

Signed-off-by: Aditya aditya050995@gmail.com

adityapande-1995 commented 1 year ago

Besides the test failures, can we also add a test for this to launch_yaml?

Done !

wjwwood commented 1 year ago

Redundant? https://github.com/ros2/launch/pull/607

wjwwood commented 1 year ago

Since this has tests, maybe we should close https://github.com/ros2/launch/pull/607?

adityapande-1995 commented 1 year ago

CI :