python expressions substitution include names of all parents for specified modules

ros2 / launch

Tools for launching multiple processes and for writing tests involving multiple processes.

Apache License 2.0

126 stars 144 forks source link

python expressions substitution include names of all parents for specified modules #688

Open zflat opened 1 year ago

zflat commented 1 year ago

This updates the python expression substitution to help with specifying python modules that are within a package.

Addresses issue https://github.com/ros2/launch/issues/687

zflat commented 1 year ago

@adityapande-1995 Can I please get a review?

zflat commented 1 year ago

Overall, I think this change is valuable. I've left one thing to change, but once that is fixed I think we can run CI on it.

Thanks @clalancette for the fix to the copy & paste error. Much better to have an appropriate failure reason reported.

clalancette commented 1 year ago

CI:

Linux
Linux-aarch64
Windows

clalancette commented 1 year ago

So it looks like this caused a hang in the launch tests on all platforms. @zflat Can you take a look? It may the case that this just needs a rebase, but also please try to run the tests locally and make sure that they pass.