Open SammyRamone opened 1 year ago
Sorry for the delay, I was on a short vaccation. As stated in my reply above, I changed the implementation so that the envvar overrides the everything. I also added a small note in the doc string.
@clalancette's proposal is fine with me.
If we wanted to be really thorough, we could have what you suggest as well as an "override" env var which let you explicitly set it even if something else has been set in the code. This would be just for debugging situations I guess. But doing just what you suggested is sufficient probably.
I changed the PR to the the proposed priority ordering of @clalancette. Please re-review it.
friendly ping @clalancette I also fixed a missing sign off in the last commit.
I also added a draft PR for documenting this PR https://github.com/ros2/ros2_documentation/pull/4061
friendly ping @fujitatomoya @wjwwood
friendly ping @wjwwood @fujitatomoya I would be happy to get this finally merged to be able to merge https://github.com/ros2/ros2_documentation/pull/4061 As far as I can see it the failing check is a problem of Jenkin itself with some missing flake8 package.
I would be really happy if we could move this PR forward. Its been almost a year since I created it.
Can we somehow get forward with this PR, please? @wjwwood @fujitatomoya @adityapande-1995 @methylDragon @clalancette
The failing checks are just an issue from the CI and I don't know why it says "changes requested", as I incorporated all changes that were requested. As far as I see, this PR is ready to merge. It just needs someone to give it another review. This PR also still blocks https://github.com/ros2/ros2_documentation/pull/4061 @wjwwood @fujitatomoya @adityapande-1995 @methylDragon @clalancette
This PR would close https://github.com/ros2/launch/issues/664
I used a constant to get the default value instead of
self.__init__.__defaults__[6]
since adding any further arguments would break the code in that case. Any feedback is welcome.