Closed SammyRamone closed 7 months ago
friendly ping @adityapande-1995 @methylDragon @wjwwood
Sorry for the long wait. This was fairly low-priority for me and I only now had time to work on it again. I added a test for the environment variables and also ensured that the other tests don't fail if the environment variable is set in the terminal in which the tests are executed.
I also added a draft PR for documenting this PR https://github.com/ros2/ros2_documentation/pull/4061
friendly ping @methylDragon
@SammyRamone thanks for the patience ! The team had a discussion about this, and while we do think there should be a holistic way to configure all of this logging, this is a good feature. I'll run full CI on this.
This is a proposed fix for https://github.com/ros2/launch_ros/issues/368 Originally, I planned on reusing the
RCUTILS_CONSOLE_OUTPUT_FORMAT
environment variable for this. Hoewever, this is not possible since launch and rcutils rely on two different logging implementations which have different names for the same things. For example one supports {line_number} and the other {lineno}. Instead I added two environment variablesOVERRIDE_LAUNCH_SCREEN_FORMAT
andOVERRIDE_LAUNCH_LOG_FORMAT
since screen and log formatting is handled differently in the code. I also framed the variables as override similar to https://github.com/ros2/launch/pull/713Any feedback is welcome.