ros2 / launch

Tools for launching multiple processes and for writing tests involving multiple processes.
Apache License 2.0
125 stars 139 forks source link

Rework task exceptions loop. #755

Closed clalancette closed 8 months ago

clalancette commented 8 months ago

The original reason to do this was because mypy was having a difficult time ensuring that the final raised exception was valid. This fixes that problem.

But this also should be much faster. Before we were iterating over the list 3 times; once to the collect the exceptions, once to filter out None, and once to them print them out. Instead, this just iterates once, dispatching everything properly.

adityapande-1995 commented 8 months ago