search

ros2 / launch

Tools for launching multiple processes and for writing tests involving multiple processes.
Apache License 2.0
117 stars 138 forks source link

Let XML executables/nodes be "required" (like in ROS 1) (#751) #764

Closed Timple closed 4 months ago

Timple commented 4 months ago

Backport of https://github.com/ros2/launch/pull/751 for ROS iron

Thanks @m-elwin for the works!

fujitatomoya commented 4 months ago

@mjcarroll can you review this and run CI?

mjcarroll commented 4 months ago

CI running against iron

Timple commented 4 months ago

Flake8 complains: ./launch/launch_context.py:24:1: F401 'typing.Mapping' imported but unused. But it's not part of this PR. Would you like me to fix it, or is this out of scope?

mjcarroll commented 4 months ago

Would you like me to fix it, or is this out of scope?

Let's go ahead and fix it here so we can keep CI green.

Timple commented 4 months ago

Now the tests are stating:

/launch/launch_context.py:66:40: F821 undefined name 'Mapping'

Which I removed because 'Mapping' was indicated as unused import. I hope this can be considered out of scope for this PR as I don't have an idea how to solve this :slightly_frowning_face: Locally all tests are happy.

Timple commented 3 months ago

@Yadunund since you did the last release, do you know what the policy is for getting a new release on iron? :slightly_smiling_face:

Yadunund commented 3 months ago

Version bumps to core packages (including launch) would be part of a patch release and I was aiming to do the next one around 19th April.

Timple commented 3 months ago

Cool :sunglasses: