search

ros2 / launch

Tools for launching multiple processes and for writing tests involving multiple processes.
Apache License 2.0
126 stars 144 forks source link

Use yaml types #781

Open InvincibleRMC opened 6 months ago

InvincibleRMC commented 6 months ago

I notice yaml was given a #type: ignore but that is no longer necessary with python3-types-pyaml

fujitatomoya commented 5 months ago

CI:

fujitatomoya commented 5 months ago

@InvincibleRMC can you address https://ci.ros2.org/job/ci_linux/21236/testReport/junit/launch.test/test_mypy/test_mypy/?

InvincibleRMC commented 5 months ago

Strange it cannot find types-pyaml error: Library stubs not installed for "yaml" [import-untyped]

InvincibleRMC commented 5 months ago

Hmm I might be wrong but looking at this we might need to add the install in ros2ci itself.

InvincibleRMC commented 5 months ago

Made a pr over at https://github.com/ros2/ci/pull/781 to hopefully address this problem.