Increase the timeout in wait_for_topic_launch_test.

ros2 / launch_ros

Tools for launching ROS nodes and for writing tests involving ROS nodes.

Apache License 2.0

60 stars 74 forks source link

Increase the timeout in wait_for_topic_launch_test. #377

Closed clalancette closed 1 year ago

clalancette commented 1 year ago

In commit 0c081a7791f9b0ab535ce6a60776e1752cdc22c7 (https://github.com/ros2/launch_ros/pull/360) we increased the timeout to 10 seconds to accomodate slower discovery. However, this was partially reverted in 2d125a5105bbfc1d34de17dd70c29905e3ce9732 (https://github.com/ros2/launch_ros/pull/353).

Restore the 10 second timeout to avoid flakes on the buildfarm.

clalancette commented 1 year ago

CI:

Linux
Linux-aarch64
Windows

Ryanf55 commented 9 months ago

Is there a more "robust" way to do this in CI without hard-coded delay? 10 seconds seems pretty long for a single discovery channel, no?

We're facing the same issues with the delays in internal CI, except it's dropping samples and causing test failures in our system tests, which hang up our release pipelines to prod.

More context on related issue: https://github.com/ros2/launch_ros/pull/356#discussion_r1496793049