added type hinting in launch_ros/launch_testing_ros/test/examples

ros2 / launch_ros

Tools for launching ROS nodes and for writing tests involving ROS nodes.

Apache License 2.0

60 stars 74 forks source link

added type hinting in launch_ros/launch_testing_ros/test/examples #385

Closed yaswanth1701 closed 12 months ago

yaswanth1701 commented 12 months ago

Closes issue #366 SUMMARY: Added python type hinting support for all the examples in launch_ros/launch_testing_ros/test

yaswanth1701 commented 12 months ago

yes !! working on it

yaswanth1701 commented 12 months ago

Hi @clalancette, I am done with the required changes can you please review them?

yaswanth1701 commented 12 months ago

I am sorry I created a lot of mess here, I think force pushing from the start or creating of new PR with all the changes would be a better option. What would you say?

clalancette commented 12 months ago

I am sorry I created a lot of mess here, I think force pushing from the start

Force pushing is just fine; I'd prefer to do that rather than create a new PR.

yaswanth1701 commented 12 months ago

okay, I will close this PR and create a new one.