search

ros2 / launch_ros

Tools for launching ROS nodes and for writing tests involving ROS nodes.
Apache License 2.0
58 stars 72 forks source link

`WaitForTopics`: get content of messages for each topic (backport #353) #389

Closed mergify[bot] closed 8 months ago

mergify[bot] commented 8 months ago

This is an automatic backport of pull request #353 done by Mergify. Cherry-pick of 2d125a5105bbfc1d34de17dd70c29905e3ce9732 has failed:

On branch mergify/bp/humble/pr-353
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 2d125a5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   launch_testing_ros/launch_testing_ros/wait_for_topics.py
    both modified:   launch_testing_ros/test/examples/wait_for_topic_launch_test.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Mergify commands and options
More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport ` will backport this PR on `` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com
Ryanf55 commented 8 months ago

LGTM with full green CI

There were conflicts. Do you want me to push a commit to resolve them?

adityapande-1995 commented 8 months ago

Yup, that would be great, thanks !

Ryanf55 commented 8 months ago

Sorry, I got sidetracked. colcon test fails because this bug that hasn't made it into a release, and missed the humble sync in January. https://github.com/ament/ament_lint/pull/464

Then, I tried to run the release myself and ran into this bug in bloom. https://github.com/ros-infrastructure/bloom/issues/722

So, I compiled bloom and ament_lint from source, and then ran into this issue. https://github.com/ament/ament_lint/issues/437#issuecomment-1894836832

Regardless, here's the fixes. I can't push to the branch, so I made a PR. I had to use docker to test it because host OS has different behavior than ros:humble. https://github.com/ros2/launch_ros/pull/390

adityapande-1995 commented 8 months ago
clalancette commented 8 months ago

Sorry, I got sidetracked. colcon test fails because this bug that hasn't made it into a release, and missed the humble sync in January.

No, that shouldn't be the case. We always use the debian packages for the tests, which is version 4.0.1. And looking at the test failures, they aren't failing because of the flake8 version. Something else is going on here.

Ryanf55 commented 8 months ago

Sorry, I got sidetracked. colcon test fails because this bug that hasn't made it into a release, and missed the humble sync in January.

No, that shouldn't be the case. We always use the debian packages for the tests, which is version 4.0.1. And looking at the test failures, they aren't failing because of the flake8 version. Something else is going on here.

Should I make a new ticket?

clalancette commented 8 months ago

Should I make a new ticket?

I don't think so; whatever is happening here seems to be because of this PR.

Ryanf55 commented 8 months ago

Should I make a new ticket?

I don't think so; whatever is happening here seems to be because of this PR.

Interesting idea. Not sure if you saw, but I did get colcon test to pass in #390, which I demonstrated in a docker ros:humble container. The latest CI logs say there are conflicts on the VCS checkout which doesn't make sense because I fixed them.

clalancette commented 8 months ago

Interesting idea. Not sure if you saw, but I did get colcon test to pass in #390, which I demonstrated in a docker ros:humble container. The latest CI logs say there are conflicts on the VCS checkout which doesn't make sense because I fixed them.

Oh, that's because this was run with the rolling ros2.repos, not the humble one. CI needs to be rerun against humble.

Ryanf55 commented 8 months ago

Interesting idea. Not sure if you saw, but I did get colcon test to pass in #390, which I demonstrated in a docker ros:humble container. The latest CI logs say there are conflicts on the VCS checkout which doesn't make sense because I fixed them.

Oh, that's because this was run with the rolling ros2.repos, not the humble one. CI needs to be rerun against humble.

Can anyone do this? I don't see how, and it would be great to get this in.

mjcarroll commented 8 months ago

Usign https://raw.githubusercontent.com/ros2/ros2/humble/ros2.repos

mjcarroll commented 8 months ago

Trying again, actually setting platforms to use humble deps: