search

ros2 / libyaml_vendor

CMake wrapper downloading and building libyaml
Apache License 2.0
2 stars 17 forks source link

Quality declaration for external dependency libyaml #14

Closed Blast545 closed 4 years ago

Blast545 commented 4 years ago

This is a quality declaration for libyaml external dependency for ROS2 packages as described in the proposed REP-2004.

This declaration represents some thoughts regarding the current state of this external dependency and how this affect Quality Level 1 for ROS2 packages.

Signed-off-by: Jorge Perez jjperez@ekumenlabs.com

Blast545 commented 4 years ago

I'll hold merging this until it's confirmed if we are aiming to merge with the current state Quality Level or if we'd like to argument the minimal requirements to achieve level 1.

Blast545 commented 4 years ago

Added a section explaining a couple of steps to follow to consider improving Quality Level of the external dependency.

Blast545 commented 4 years ago

Waiting until DCO is enabled for this package before merging QD.

chapulina commented 4 years ago

Waiting until DCO is enabled for this package before merging QD.

DCO checks have been installed on this repo, could you try pushing something to this PR to see if it works?

Blast545 commented 4 years ago

Could you try pushing something to this PR to see if it works?

Just tested pushing without signature, and I can see DCO is failing, great!