search

ros2 / libyaml_vendor

CMake wrapper downloading and building libyaml
Apache License 2.0
2 stars 17 forks source link

Foxy Version Fails with Cmake 3.10 - Unknown CMake command "target_link_directories".' #33

Closed mrawding closed 3 years ago

mrawding commented 3 years ago

In the master version, it does a check for the CMake version before using the target_link_directories command. However, on the foxy branch it does not. This results in an error when building ROS foxy from source with a CMake version less than 3.13, although the minimum required is 3.9.

This is in the master version and in foxy-backport. Which should work if ros_base foxy repos pointed to master.

      link_directories(${yaml_LIBRARY_DIRS})
    else()
      target_link_directories(test_yaml_reader PRIVATE ${yaml_LIBRARY_DIRS})

However it seems that ros_base links to the foxy library and not foxy-backport. Is there a way we can change this for the source install from r

 rosinstall_generator ros_base --deps --rosdistro foxy > ros2-base.repos

So that it points to the correct branch?

clalancette commented 3 years ago

See #29. Once that is merged, the problem will be fixed on the 'foxy' branch.

clalancette commented 3 years ago

This was fixed in #29, so closing.