search

ros2 / libyaml_vendor

CMake wrapper downloading and building libyaml
Apache License 2.0
2 stars 17 forks source link

Foxy build fails on libyaml #47

Closed jarekkt closed 2 years ago

jarekkt commented 2 years ago

Could you have a look ? I have been trying to build latest Foxy on Jetson TX2 and it fails on one of your latest changes. See original issue: https://github.com/dusty-nv/jetson-containers/issues/132

Full build log in original issue, here brief:

Finished <<< rosidl_typesupport_introspection_c [11.0s] Starting >>> rosidl_typesupport_introspection_cpp --- stderr: libyaml_vendor Cloning into 'libyaml-0.2.5'... HEAD is now at 2c891fc Changes for v0.2.5 release error: can't open patch '/opt/ros/foxy/src/libyaml_vendor/0001-Install-yaml.h-to-INSTALL_INCLUDE_DIR.patch': No such file or directory make[2]: [libyaml-0.2.5-prefix/src/libyaml-0.2.5-stamp/libyaml-0.2.5-patch] Error 128 make[1]: [CMakeFiles/libyaml-0.2.5.dir/all] Error 2 make: *** [all] Error 2

jarekkt commented 2 years ago

Ok, few more things found.

ROS 2 build for foxy had following issue: https://github.com/dusty-nv/jetson-containers/issues/41#issuecomment-774767272

It was fixed by adding patch which takes CMakeLists.txt from main.

patch libyaml -

rm ${ROS_ROOT}/src/libyaml_vendor/CMakeLists.txt && \
wget --no-check-certificate https://raw.githubusercontent.com/ros2/libyaml_vendor/master/CMakeLists.txt -P ${ROS_ROOT}/src/libyaml_vendor/ && \

But it fails now once the new CMakeLists.txt contains new reference.

I will make some tests ( to see if the patch is still needed) and let you know the rsult.

jarekkt commented 2 years ago

I can confirm that removing the patch in jetson build script fixes the issue