ros2 / message_filters

BSD 3-Clause "New" or "Revised" License
76 stars 66 forks source link

Fixes pointed out by clang #104

Closed clalancette closed 1 year ago

clalancette commented 1 year ago
  1. Make one of the SubscriptionBase::subscribe methods pure virtual. That's because it only ever called itself, which is nonsensical. That just means that all classes that derive from it must implement it.
  2. Make clang aware that one of the tests here just wants to test that equality doesn't throw, so we don't care about the result.
clalancette commented 1 year ago

CI: