Message filters rework port in progress for review

tfoote commented 6 years ago

This is a rework of #4 for better traceability of code origin as well as some cleanup.

I've been splitting it into many different commits for easier auditing. I've separated out copying in files from different locations from converting them to the new syntax.

After that restructuring I've then gone through and been doing reviews of the changes.

There's now more commits in the history than I plan to have at the end. Several of the later ones are reverting non-essential changes earlier. I plan to find where they were changed and squash the revert of the changes down.

Outstanding TODOs

implement correct solutions for

[x] ROS_WARN -> cout
[x] ROS_ASSERT -> assert
[x] ROS_BREAK -> std::abort
[x] Commented asserts such as in test_subscriber.cpp
[x] time_sequencer_unittest.cpp:135 ros::Time::setNow(ros::Time::now() + ros::Duration(2)); removed from test.

@j-rivero @mjcarroll @gaoethan If you could take a look and give any feedback/comments suggestions I'll pull them in as i finish my audit and cleanup before a final review.

@mjcarroll Please look closely at c7f8d24 and https://github.com/ros2/message_filters/commit/abe143a5d197e71f54b1e866c636e1e58d282cd8 It's a slight change in the API that I made based on talking with @wjwwood

dirk-thomas commented 6 years ago

Should ROS 1 specific concepts like connection headers, caller id, etc. be removed?

gaoethan commented 6 years ago

@tfoote it works within my Ubuntu bionic, thanks for your effort 👍

tfoote commented 6 years ago

Thanks for the reviews. I believe I've addressed all comments and have now finished cleaning up all items I flagged as well. It's ready for a review.

ros2 / message_filters

Message filters rework port in progress for review #5

Outstanding TODOs