search

ros2 / message_filters

BSD 3-Clause "New" or "Revised" License
76 stars 66 forks source link

Suppress rclcpp deprecation warnings in unit tests #62

Closed aprotyas closed 3 years ago

aprotyas commented 3 years ago

ros2/rclcpp#1713 deprecates the void shared_ptr<T> subscription callback signatures, so this PR introduces the RCLCPP_AVOID_DEPRECATIONS_FOR_UNIT_TESTS macro to suppress warnings from the tests requiring these deprecated signatures.

Said tests (those with NonConstHelper) have to be removed once the deprecated signatures are removed from rclcpp.

Signed-off-by: Abrar Rahman Protyasha abrar@openrobotics.org

aprotyas commented 3 years ago

CI (build/test: --packages-above-and-dependencies message_filters)

aprotyas commented 3 years ago

Ignore the botched CI job. The warnings came from interactive_markers, where I didn't push the patch to deal with the deprecation and in robot_state_publisher, which used the repo from the ros org and not my fork.

I am running a full CI instead to target all the changes necessitated by the deprecation in ros2/rclcpp#1713.

aprotyas commented 3 years ago

Yellow CI for Windows is unrelated to this package - originates from system_tests packages.