search

ros2 / message_filters

BSD 3-Clause "New" or "Revised" License
76 stars 66 forks source link

[Question] Why the limit of synchronizer is 9 topics? #91

Closed Tumb1eweed closed 1 year ago

Tumb1eweed commented 1 year ago

Since c++11 already support variadic template, should synchronizer have no topic number limit or is it another way to achieve this without modifying it?

clalancette commented 1 year ago

Since c++11 already support variadic template, should synchronizer have no topic number limit or is it another way to achieve this without modifying it?

I think it is mostly the fact that the synchronizer was written before C++11. We'd be fine with having it rewritten with variadic templates, just nobody has had time to do it. If you are interested in looking into it and opening a PR, we'd be happy to review.

Tumb1eweed commented 1 year ago

Since c++11 already support variadic template, should synchronizer have no topic number limit or is it another way to achieve this without modifying it?

I think it is mostly the fact that the synchronizer was written before C++11. We'd be fine with having it rewritten with variadic templates, just nobody has had time to do it. If you are interested in looking into it and opening a PR, we'd be happy to review.

Oh, i see the PR now, thanks for answering!