Closed cwecht closed 4 months ago
@mjcarroll any update on this?
There are many conflicts
Sort-of to be expected after 1+ years in the queue, right?
I'm happy to update this PR. I'll have a look at it soon.
I made these changes https://github.com/ros-perception/image_pipeline/pull/1015 and it's working, I would perfer not to do it, to avoid affect other users.
I now reintroduced the TimeSynchronizers old constructors but with a deprecation marking. That's why their are new warnings in the build.
There are some new warnings https://build.ros2.org/job/Rpr__message_filters__ubuntu_noble_amd64/83/clang-tidy/new/
Yes, that's entended. The idea is to keep the old constructors in order to not break builds but mark them as "deprecated" as suggested in the ROS 2 developer guide. Marking these constructors as deprecated causes the new warnings.
However, of cause we could just keep the old constructors and not mark them deprecated, but I suggest that we should remove them as they are quite redundant.
Thank you for the refactoring and the iterations
This PR mirgates message_synchronisers to variadic templates and allows for arbitrary numbers of topics.
Please note, that TimeSynchronizer had to be shruken down significantly for two reasons:
Given these changes, it might make sense to make TimeSynchronizer a template alias rather than a template class.