search

ros2 / orocos_kdl_vendor

Apache License 2.0
2 stars 6 forks source link

Make sure to quote orocos variables when setting targets. #12

Closed clalancette closed 2 years ago

clalancette commented 2 years ago

If the variables happen to have semicolons in them, then an unquoted version means that we get CMake errors about set_target_properties having the wrong number of arguments. Make sure to quote all of the variables.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

I noticed this while attempting to build pcl_ros locally; I kept getting the aforementioned set_target_properties error. I don't understand why this wasn't a problem while building https://build.ros2.org packages, but only locally. Still, I think this is the correct fix.

clalancette commented 2 years ago

Just for future reference, what actually happened on my machine was that orocos_kdl_INCLUDE_DIRS contained /usr/include;/usr/include/eigen3, and that's what caused the set_target_properties error.

Here's full CI to make sure this is happy. Assuming all is well with that, I'll merge it in and then also do a backport to Humble.

cottsay commented 2 years ago

Test failures appear unrelated to me. +1 to merge and release this.

cottsay commented 2 years ago

@Mergifyio backport humble

mergify[bot] commented 2 years ago

backport humble

✅ Backports have been created

* [#14 Make sure to quote orocos variables when setting targets. (backport #12)](https://github.com/ros2/orocos_kdl_vendor/pull/14) has been created for branch `humble`