search

ros2 / performance_test

Tool to test the performance of pub/sub based communication frameworks.
Apache License 2.0
13 stars 6 forks source link

Build failing with Fast-DDS #19

Closed ivanpauno closed 4 years ago

ivanpauno commented 4 years ago

This line causes an error

https://github.com/ros2/performance_test/blob/df75c932e4c4e7c22cb57b8f120ac04660d9e177/performance_test/src/communication_abstractions/fast_rtps_communicator.hpp#L29

Because that API was deleted in https://github.com/eProsima/Fast-DDS/pull/1227.

I only could reproduce locally, I'm not sure why nightlies aren't failing. We're using 2.0.x Fast-DDS branch in Foxy ...

We're also using -DPERFORMANCE_TEST_FASTRTPS_ENABLED=1 cmake option there.

ivanpauno commented 4 years ago

I only could reproduce locally, I'm not sure why nightlies aren't failing. We're using 2.0.x > Fast-DDS branch in Foxy ...

We're also using -DPERFORMANCE_TEST_FASTRTPS_ENABLED=1 cmake option there.

@cottsay @ahcorde any idea why this is not failing on CI and only locally?

ivanpauno commented 4 years ago

@richiware FYI

richiware commented 4 years ago

Thanks for the ping. I've created a PR #20 fixing this issue.

ivanpauno commented 4 years ago

@cottsay friendly ping about this question https://github.com/ros2/performance_test/issues/19#issuecomment-644963348.

Foxy performance tests nightly is supposed to be using FastRTPS 2.0, but it seems not to be using it.

cottsay commented 4 years ago

any idea why this is not failing on CI and only locally?

I'm trying to debug this, but evidently our CI workers took a hike list night. I'll report back if I find anything interesting.