ros2 / performance_test

Tool to test the performance of pub/sub based communication frameworks.
Apache License 2.0
13 stars 6 forks source link

:woman_farmer: uncrustify regression on `connext_dds_micro_communicator` test for all distros #49

Closed claraberendsen closed 2 months ago

claraberendsen commented 3 months ago

Description

There seems to be a test regression on all distros for the test connext_dds_micro_communicator

The error is

--- src/communication_abstractions/connext_dds_micro_communicator.hpp
+++ src/communication_abstractions/connext_dds_micro_communicator.hpp.uncrustify
@@ -295 +295,2 @@
-  static auto init_data(T & data)->decltype (data.header_.frame_id_, void ()) {
+  static auto init_data(T & data)->decltype (data.header_.frame_id_, void ())
+  {
@@ -317 +318,2 @@
-  static auto init_fields(T & data)->decltype (data.fields_, void ()) {
+  static auto init_fields(T & data)->decltype (data.fields_, void ())
+  {

Affected builds

Blast545 commented 2 months ago

I fixed this on main with: https://github.com/ros2/performance_test/pull/53, feel free to close it whenever you want, as I will be tracking the backports with https://github.com/ros2/performance_test/issues/48, which is technically the same issue.

clalancette commented 2 months ago

Thanks!