search

ros2 / rcl

Library to support implementation of language specific ROS Client Libraries.
Apache License 2.0
130 stars 163 forks source link

Properly initialize the char array used in type hash calculations. (backport #1182) #1184

Closed mergify[bot] closed 1 month ago

mergify[bot] commented 1 month ago

Previously, we were zero initializing it and only setting up one of its fields. But that doesn't totally properly initialize it; we really should call rcutils_char_array_init to make sure everything is initialized. Do that in the live source, as well as in the test for it.

This bug was exposed by https://github.com/ros2/rcutils/pull/478 . @fujitatomoya @emersonknapp FYI

This is an automatic backport of pull request #1182 done by Mergify.

ahcorde commented 1 month ago

Pulls: ros2/rcl#1184 Gist: https://gist.githubusercontent.com/ahcorde/58a734b2346e681ac006de792d76e40e/raw/650396cc3a73dfd3b73775558c9b2bafac4c1e21/ros2.repos BUILD args: --packages-above-and-dependencies rcl --packages-above-and-dependencies rcl TEST args: --packages-above rcl --packages-above rcl ROS Distro: iron Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14571