Closed ahcorde closed 1 month ago
I haven't been able to reproduce this test failure on my machine with the latest rolling branches for both rmw_zenoh and this repo.
rolling
rmw_zenoh
I run all the tests
colcon test --event-handlers console_direct+ --packages-select rcl_lifecycle
On my machine the 4 gtests takes about 42 with rmw_zenoh/rolling
rmw_zenoh/rolling
100% tests passed, 0 tests failed out of 10 Label Time Summary: copyright = 3.40 sec*proc (1 test) cppcheck = 0.51 sec*proc (1 test) cpplint = 1.21 sec*proc (1 test) gtest = 42.31 sec*proc (4 tests) lint_cmake = 0.46 sec*proc (1 test) linter = 7.36 sec*proc (6 tests) uncrustify = 0.59 sec*proc (1 test) xmllint = 1.18 sec*proc (1 test) Total Test time (real) = 49.68 sec Finished <<< rcl_lifecycle [51.0s] Summary: 1 package finished [52.6s]
With rmw_fastrtps, it takes 2s.
rmw_fastrtps
100% tests passed, 0 tests failed out of 10 Label Time Summary: copyright = 3.37 sec*proc (1 test) cppcheck = 0.48 sec*proc (1 test) cpplint = 1.18 sec*proc (1 test) gtest = 2.18 sec*proc (4 tests) lint_cmake = 0.46 sec*proc (1 test) linter = 6.91 sec*proc (6 tests) uncrustify = 0.59 sec*proc (1 test) xmllint = 0.82 sec*proc (1 test) Total Test time (real) = 9.09 sec Finished <<< rcl_lifecycle [10.4s] Summary: 1 package finished [11.9s]
I opened https://github.com/ros2/rmw_zenoh/pull/284 to reduce the sleep in rmw_init in rmw_zenoh and now the test only takes 30s with rmw_zenoh.
rmw_init
100% tests passed, 0 tests failed out of 10 Label Time Summary: copyright = 3.39 sec*proc (1 test) cppcheck = 0.50 sec*proc (1 test) cpplint = 1.18 sec*proc (1 test) gtest = 30.20 sec*proc (4 tests) lint_cmake = 0.47 sec*proc (1 test) linter = 7.03 sec*proc (6 tests) uncrustify = 0.60 sec*proc (1 test) xmllint = 0.89 sec*proc (1 test) Total Test time (real) = 37.24 sec Finished <<< rcl_lifecycle [38.5s] Summary: 1 package finished [40.1s]
It's a slight improvement. @ahcorde could you confirm that this test still fails on rolling for your and if so, does my PR improve the situation?
Thank you @Yadunund !
I haven't been able to reproduce this test failure on my machine with the latest
rolling
branches for bothrmw_zenoh
and this repo.I run all the tests
On my machine the 4 gtests takes about 42 with
rmw_zenoh/rolling
With
rmw_fastrtps
, it takes 2s.I opened https://github.com/ros2/rmw_zenoh/pull/284 to reduce the sleep in
rmw_init
inrmw_zenoh
and now the test only takes 30s withrmw_zenoh
.It's a slight improvement. @ahcorde could you confirm that this test still fails on
rolling
for your and if so, does my PR improve the situation?