search

ros2 / rcl

Library to support implementation of language specific ROS Client Libraries.
Apache License 2.0
130 stars 163 forks source link

Expect a minimum of two nodes to be alive in test_graph #1192

Closed Yadunund closed 1 month ago

Yadunund commented 1 month ago

Addresses https://github.com/ros2/rcl/issues/1189

Yadunund commented 1 month ago

CI started with https://gist.githubusercontent.com/Yadunund/fc9014a21560fe9728ff03ade81b3009/raw/2486b9aae3dcd98571be453e4155359f348a19d6/ros2.repos

Yadunund commented 1 month ago

CI is failing with rmw_fastrtps_cpp even for test cases unmodified in this PR. Is there a regression with FastDDS?

fujitatomoya commented 1 month ago

we suspected https://github.com/ros2/rmw_fastrtps/commit/565bbc22357413aa7342e9dd0d6518b71f7f10a6 but https://github.com/ros2/rmw_fastrtps/pull/780 looks fine with CI.

in Fast-DDS 2.14.x, there are few commits https://github.com/eProsima/Fast-DDS/commits/2.14.x/, but i am not sure which one triggers that.

Yadunund commented 1 month ago

@fujitatomoya thanks for the insights. I will run CI on this PR after another review.

YuanYuYuan commented 1 month ago

Hi @Yadunund. I think we need to change the logic in rcl_action as well.

https://github.com/ros2/rcl/blob/1e565d56551f193b5cb1461a6ed71015508f7485/rcl_action/test/rcl_action/test_graph.cpp?plain=1#L328-L357

After the change, we should conquer the failures in rcl_action test_graph.

Yadunund commented 1 month ago

Hi @Yadunund. I think we need to change the logic in rcl_action as well.

https://github.com/ros2/rcl/blob/1e565d56551f193b5cb1461a6ed71015508f7485/rcl_action/test/rcl_action/test_graph.cpp?plain=1#L328-L357

After the change, we should conquer the failures in rcl_action test_graph.

Nice catch. Done https://github.com/ros2/rcl/pull/1192/commits/1ad5d9e833a4b13bd0123e7ae44e55c5e27e4736

clalancette commented 1 month ago

Pulls: https://github.com/ros2/rcl/pull/1192 Gist: https://gist.githubusercontent.com/clalancette/9c99ce9f776fd5378e610788e890ce4e/raw/af98cfe6a867bdd7473bff053cbcbfff72fcc363/ros2.repos BUILD args: --packages-up-to rcl rcl_action TEST args: --packages-select rcl rcl_action ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14638