search

ros2 / rcl_interfaces

A repository for messages and services used by the ROS client libraries
Apache License 2.0
40 stars 43 forks source link

Enforce static parameter typing #118

Closed ivanpauno closed 3 years ago

ivanpauno commented 3 years ago

Alternative to https://github.com/ros2/rcl_interfaces/pull/115. See https://github.com/ros2/rclcpp/pull/1522 for details.

ivanpauno commented 3 years ago

@jacobperron @mjeronimo PTAL to this and https://github.com/ros2/rclcpp/pull/1522, most of the feedback was addressed. Deprecating node->declare_parameter("name") is the only pending thing (I think).

ivanpauno commented 3 years ago

Deprecating node->declare_parameter("name") is the only pending thing (I think).

Done that too

ivanpauno commented 3 years ago

Merging this one before than the others, so I can release and make sure that all the PR checker jobs of downstream PRs are passing.