search

ros2 / rcl_interfaces

A repository for messages and services used by the ROS client libraries
Apache License 2.0
38 stars 42 forks source link

Add interfaces for logging service. #154

Closed llapx closed 1 year ago

llapx commented 1 year ago

this PR is a component of #https://github.com/ros2/rclcpp/pull/2122

fujitatomoya commented 1 year ago

@llapx as interface, it looks good to me. just requesting update https://github.com/ros2/rcl_interfaces/blob/rolling/rcl_interfaces/README.md with additional message and service files.

llapx commented 1 year ago

@llapx as interface, it looks good to me. just requesting update https://github.com/ros2/rcl_interfaces/blob/rolling/rcl_interfaces/README.md with additional message and service files.

Updated, thanks.

fujitatomoya commented 1 year ago

@gbiggs requesting review on this.

fujitatomoya commented 1 year ago

I am not sure who to ask the review, since @gbiggs (maintainer according to pacakge.xml) not responding?

CC: @ros2/dev

fujitatomoya commented 1 year ago

@iuhilnehc-ynos can you review this?

Barry-Xu-2018 commented 1 year ago

Rebase was done.

fujitatomoya commented 1 year ago

CI:

fujitatomoya commented 1 year ago

@Barry-Xu-2018 i was trying to push the fix but no permission. can you check the unresolved comments?

Barry-Xu-2018 commented 1 year ago

I updated codes based on review comments. @fujitatomoya
@clalancette Please review again.

clalancette commented 1 year ago

CI: