search

ros2 / rcl_logging

Logging implementations for ROS 2.
Apache License 2.0
22 stars 35 forks source link

add file_name_prefix parameter to external log configuration. #109

Closed fujitatomoya closed 11 months ago

fujitatomoya commented 11 months ago

address https://github.com/ros2/ros2cli/issues/856

fujitatomoya commented 11 months ago

@iuhilnehc-ynos requesting review.

fujitatomoya commented 11 months ago

@iuhilnehc-ynos requesting 2nd review.

fujitatomoya commented 11 months ago

CI:

fujitatomoya commented 11 months ago

CI:

fujitatomoya commented 11 months ago

@clalancette requesting review again, windows failure has been addressed and CI is green.

this needs to go with https://github.com/ros2/rcl/pull/1127

ZhenshengLee commented 11 months ago

Happy to see the feature, I wonder if this feature will be applied to LTS Humble?

fujitatomoya commented 11 months ago

i do not think we can do that, this breaks API.

ZhenshengLee commented 11 months ago

i do not think we can do that, this breaks API.

Thanks for your reply! Which official version will this feature be applied/released to? Iron or the future J version?

fujitatomoya commented 11 months ago

Jazzy Jalisco, see distributions for https://docs.ros.org/en/rolling/Releases.html#future-distributions.

cz000 commented 3 months ago

i do not think we can do that, this breaks API.

How can I fix this issue in LTS Humble? Do you have any idea?

fujitatomoya commented 3 months ago

@cz000 this change breaks ABI compatibility, so we cannot backport this fix to humble or iron. something you can do is to cherry-pick the fix and build the package from the humble source code.