search

ros2 / rcl_logging

Logging implementations for ROS 2.
Apache License 2.0
20 stars 36 forks source link

rcl_logging_interface is only valid path with build environment. #122

Closed fujitatomoya closed 1 month ago

fujitatomoya commented 1 month ago

closes https://github.com/ros2/rcl_logging/issues/121

fujitatomoya commented 1 month ago

@gergondet-woven

I think i was misunderstanding, I am not 100% sure but I think @sloretz 's comment https://github.com/ros2/rcl_logging/pull/122#pullrequestreview-2334345059 is correct. rcl_logging_spdlog needs to export the dependency on rcl_logging_interface, so putting ament_export_dependencies(rcl_logging_interface) back to see if the problem solves?

gergondet-woven commented 1 month ago

so putting ament_export_dependencies(rcl_logging_interface) back to see if the problem solves?

Yes, this would work as well and it's even more correct.

I have also confirmed that I had no scrapping issues in that case since the rcl_logging_interface::rcl_logging_interface is correctly imported before the rcl_logging_spdlog defines its targets.

fujitatomoya commented 1 month ago

@sloretz @gergondet-woven could you review one more time?

ahcorde commented 1 month ago

Pulls: ros2/rcl_logging#122 Gist: https://gist.githubusercontent.com/ahcorde/d01cd595cc9a1be19db5cdb3f823f200/raw/b71a04a9d35d807536727ae4a258d53cd5b6fdbb/ros2.repos BUILD args: --packages-above-and-dependencies rcl_logging_noop rcl_logging_spdlog --packages-above-and-dependencies rcl_logging_noop rcl_logging_spdlog TEST args: --packages-above rcl_logging_noop rcl_logging_spdlog --packages-above rcl_logging_noop rcl_logging_spdlog ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14635

clalancette commented 1 month ago

@Mergifyio backport jazzy iron humble

mergify[bot] commented 1 month ago

backport jazzy iron humble

✅ Backports have been created

* [#123 rcl_logging_interface is only valid path with build environment. (backport #122)](https://github.com/ros2/rcl_logging/pull/123) has been created for branch `jazzy` * [#124 rcl_logging_interface is only valid path with build environment. (backport #122)](https://github.com/ros2/rcl_logging/pull/124) has been created for branch `iron` but encountered conflicts * [#125 rcl_logging_interface is only valid path with build environment. (backport #122)](https://github.com/ros2/rcl_logging/pull/125) has been created for branch `humble` but encountered conflicts