search

ros2 / rcl_logging

Logging implementations for ROS 2.
Apache License 2.0
20 stars 36 forks source link

Remove duplicated API definition from all `rcl_logging_*` backends #20

Closed clalancette closed 4 years ago

clalancette commented 5 years ago

It's currently the case that all of the rcl_logging_* backends (rcl_logging_spdlog, rcl_logging_log4cxx, and rcl_logging_spdlog) duplicate the API from https://github.com/ros2/rcl/blob/d655147310e3e63aff1555ad40fca1bb9cb7783e/rcl/include/rcl/logging_external_interface.h . Further, they also duplicate some of the internal type names from rcl. The reason they currently do this is so we don't have a circular dependency; since rcl depends on a "default" logging implementation, the logging implementations cannot also depend on rcl. We should think about the right way to break this dependency cycle and change all of this to use that.

clalancette commented 4 years ago

This was actually fixed a while ago, so I'm going to close this out.