[rcl_logging_spdlog] Add warnings

ros2 / rcl_logging

Logging implementations for ROS 2.

Apache License 2.0

18 stars 34 forks source link

[rcl_logging_spdlog] Add warnings #54

Closed audrow closed 3 years ago

audrow commented 3 years ago

This PR enables -Wformat=2, -Wconversion, -Woverloaded-virtual, -Wshadow, -Wnon-virtual-dtor, -Wold-style-cast, and -Wcast-qual in rcl_logging_spdlog. No source code was modified to enable these warnings.

Relies on googletest being v1.10.0 (https://github.com/ament/googletest/pull/8).

audrow commented 3 years ago

Linux
Linux-aarch64
macOS
Windows

audrow commented 3 years ago

Running different gtest versions to see if we can fix the warnings:

gtest v1.8.0 (what is currently used)
- macOS → 31 warnings
gtest v1.10.0
- macOS
Last commit on gtest that passed CI:
- macOS → 2 warnings

audrow commented 3 years ago

New CI run, after gtest has been updated to v1.10.0:

Linux
Linux-aarch64
macOS
Windows