search

ros2 / rcl_logging

Logging implementations for ROS 2.
Apache License 2.0
20 stars 36 forks source link

Use rcutils_expand_user() in rcl_logging_get_logging_directory() #59

Closed christophebedard closed 4 years ago

christophebedard commented 4 years ago

Follow-up to #53, now that rcutils_expand_user has been added (https://github.com/ros2/rcutils/pull/298).

christophebedard commented 4 years ago

I'm guessing a new release of rcutils might need to be created for the Rpr job to pass.

clalancette commented 4 years ago

I'm guessing a new release of rcutils might need to be created for the Rpr job to pass.

Agreed, I'll go ahead and do that.

clalancette commented 4 years ago

New release of rcutils is done, lets see if the PR build succeeds now.

clalancette commented 4 years ago

@ros-pull-request-builder retest this please

clalancette commented 4 years ago

CI:

clalancette commented 4 years ago

The 4 failures on Windows are flaky right now. So I'm going to go ahead and merge this, thanks for the change.