search

ros2 / rcl_logging

Logging implementations for ROS 2.
Apache License 2.0
20 stars 36 forks source link

[Foxy] Allow configuring logging directory through environment variables #69

Closed tgreier closed 3 years ago

tgreier commented 3 years ago

Backport to Foxy the following PRs:

jacobperron commented 3 years ago

This looks like a large change. It would be better to incrementally open up separate backports for each PR referenced.

Also, we should make sure that anything we backport does not break things for existing users. For example, we can't remove public headers, since we'll break any downstream code currently including them. It might be possible to workaround this issue by including the equivalent header from rcl_logging_interface from inside the old headers, if all of the function signatures are the same.

Correct me if I'm wrong, but at a glance, it looks like it should be possible to backport #53 without the other three referenced PRs. It's not as simple as cherry-picking the change, but presumably we could add equivalent API to the existing logging packages in Foxy.

tgreier commented 3 years ago

Ok, I can kill this PR and take the approach of adding the functionality to Foxy without deleting any existing public headers (no cherry-picking).

jacobperron commented 3 years ago

Ok, I can kill this PR and take the approach of adding the functionality to Foxy without deleting any existing public headers (no cherry-picking).

Sounds good. I'll go ahead and close this one then.