ros2 / rcl_logging

Logging implementations for ROS 2.
Apache License 2.0
20 stars 36 forks source link

[Foxy] Allow configuring logging directory through environment variables #70

Closed tgreier closed 3 years ago

tgreier commented 3 years ago

Backport of functionality from PR Allow configuring logging directory through environment variables #53.

This allows configuring the logging directory through environment variables using the following logic: Use $ROS_LOG_DIR if ROS_LOG_DIR is set and not empty. Otherwise, use $ROS_HOME/log, using ~/.ros for ROS_HOME if not set or if empty.

Implemented only for spd log.

Should it also be added for log4cxx? If so, should a copy of the rcl_logging_get_logging_directory API be added to the log4cxx package?

tgreier commented 3 years ago

@ivanpauno Hello, could you please review this PR?

jacobperron commented 3 years ago

Testing rcl_logging_spdlog and ROS 2 client libraries: