search

ros2 / rcl_logging

Logging implementations for ROS 2.
Apache License 2.0
20 stars 36 forks source link

Remove rcl_logging_log4cxx. #78

Closed clalancette closed 3 years ago

clalancette commented 3 years ago

We don't ever use it, and having it around causes a few problems:

  1. We have an unnecessary, and unneeded dependency on log4cxx in the core.
  2. We can't currently build against libc++ with log4cxx.
  3. Log4cxx causes some absolute paths to be in the delivered packages on Windows.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

@ivanpauno FYI, this should get rid of one more of the problems pointed out in https://github.com/ros2/rclcpp/issues/1688

clalancette commented 3 years ago

Full CI:

clalancette commented 3 years ago

The other good thing about doing this is that we'll be able to get rid of the log4cxx dependency.

Before I go ahead with this, any objections @cottsay or @nuclearsandwich ?

clalancette commented 3 years ago

Even though the full CI was a month ago, nothing substantial has changed here. So I'm just going to rely on that and the approval from @ivanpauno, and go ahead and merge this. There is probably some follow-up work in the documentation and the CI jobs that needs to be done, which I'll look at next.