Install includes to include/${PROJECT_NAME}

ros2 / rcl_logging

Logging implementations for ROS 2.

Apache License 2.0

22 stars 35 forks source link

Install includes to include/${PROJECT_NAME} #85

Closed sloretz closed 2 years ago

sloretz commented 2 years ago

Part of ros2/ros2#1150 - This eliminates issues with the include directory search order when overriding these packages by installing their includes to include/${PROJECT_NAME}

sloretz commented 2 years ago

CI (build: --packages-up-to rcl rcl_action rcl_lifecycle rcl_logging_interface rcl_logging_noop rcl_logging_spdlog test: --packages-select rcl rcl_action rcl_lifecycle rcl_logging_interface rcl_logging_noop rcl_logging_spdlog)

Linux
Linux-aarch64
Windows

sloretz commented 2 years ago

This Windows CI is weird. It passed,

12:47:49 [MSBuild] -> PASSED - Total (any severity): 0 - Quality QualityGate: 1

But then failed because of an exception raised in Java

12:47:51 ERROR: Step ‘Publish xUnit test result report’ aborted due to exception: 
12:47:51 java.lang.InterruptedException
12:47:51    at java.lang.Object.wait(Native Method)
...

I'll re-run it to see if it was a fluke.

sloretz commented 2 years ago

Windows CI re-run

sloretz commented 2 years ago

CI LGTM