search

ros2 / rclc

ROS Client Library for the C language.
Apache License 2.0
118 stars 42 forks source link

Drop build dependency on std_msgs #314

Closed cottsay closed 1 year ago

cottsay commented 1 year ago

This dependency is only needed when BUILD_TESTING is specified, and is already found via find_package() there.

Building packages with -DBUILD_TESTING=OFF should succeed in the absence of dependencies, which is why this issue came to my attention.

This change should be backported to Humble to avoid breaking the deb builds when we disable tests in the near future.

JanStaschulat commented 1 year ago

@mergify backport humble galactic foxy

mergify[bot] commented 1 year ago

backport humble galactic foxy

✅ Backports have been created

* [#315 Drop build dependency on std_msgs (backport #314)](https://github.com/ros2/rclc/pull/315) has been created for branch `humble` * [#316 Drop build dependency on std_msgs (backport #314)](https://github.com/ros2/rclc/pull/316) has been created for branch `galactic` * [#317 Drop build dependency on std_msgs (backport #314)](https://github.com/ros2/rclc/pull/317) has been created for branch `foxy`