search

ros2 / rclc

ROS Client Library for the C language.
Apache License 2.0
119 stars 42 forks source link

Revert "Decouple rosout publisher init from node init. (#351)" #352

Closed fujitatomoya closed 1 year ago

fujitatomoya commented 1 year ago

This reverts commit b5070031f3272ee9b8d03eff386da58074049290.

fujitatomoya commented 1 year ago

@JanStaschulat sorry about the confusion. i think we need to revert this since https://github.com/ros2/rclc/pull/351 depends on https://github.com/ros2/rcl/pull/1065

after https://github.com/ros2/rcl/pull/1065 is merged, we need to revert this PR again.

codecov-commenter commented 1 year ago

Codecov Report

Merging #352 (beef487) into master (b507003) will increase coverage by 0.09%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   68.96%   69.06%   +0.09%     
==========================================
  Files          16       16              
  Lines        2723     2715       -8     
  Branches      770      765       -5     
==========================================
- Hits         1878     1875       -3     
+ Misses        456      452       -4     
+ Partials      389      388       -1
Impacted Files Coverage Δ
rclc/src/rclc/node.c 83.33% <ø> (+17.70%) :arrow_up:

... and 1 file with indirect coverage changes

JanStaschulat commented 1 year ago

okay, no problem.