search

ros2 / rclc

ROS Client Library for the C language.
Apache License 2.0
118 stars 42 forks source link

Revert "Revert "Decouple rosout publisher init from node init. (#351)… #353

Closed fujitatomoya closed 1 year ago

fujitatomoya commented 1 year ago

…" (#352)"

This reverts commit 2648503e3fdcf1308bd1d3748e1f4792285cd1b1.

depends on ros2/rcl#1065 (please keep this open until ros2/rcl#1065 is merged.)

address ros2/rclcpp#2147

JanStaschulat commented 1 year ago

LGTM, waiting until pre-conditions are satisfied.

fujitatomoya commented 1 year ago

CI:

JanStaschulat commented 1 year ago

The failed test cases of the Linux CI job are not related to rclc.

For example: 

/home/jenkins-agent/workspace/ci_linux/ws/src/ros2/rclpy/rclpy/src/rclpy/node.cpp:488:  Lines should be <= 100 characters long  [whitespace/line_length] [2]
Category 'whitespace/line_length' errors found: 1
Total errors found: 1
fujitatomoya commented 1 year ago

@JanStaschulat thanks for checking on this.

all related PRs are almost ready, I will let you know once https://github.com/ros2/rcl/pull/1065#issuecomment-1598084150 goes green.

fujitatomoya commented 1 year ago

CI(rclc for Linux): all green but windows above

fujitatomoya commented 1 year ago

I will go ahead to close this one, and reopen targeted to rolling branch.