ros2 / rclc

ROS Client Library for the C language.
Apache License 2.0
119 stars 42 forks source link

Add empty set_atomically parameter service #354

Closed Acuadros95 closed 1 year ago

Acuadros95 commented 1 year ago

New parameter client implementations check the availability of all the related services before executing a command. We were missing the /set_parameters_atomically, making ROS 2 Cli parameter commands fail.

This PR adds a empty service implementation to fix this issue. Related: https://github.com/micro-ROS/micro-ROS-Agent/issues/195

Note: This fix shall be included on the Iron release.

codecov-commenter commented 1 year ago

Codecov Report

Merging #354 (72621aa) into master (2648503) will increase coverage by 0.42%. The diff coverage is 95.55%.

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
+ Coverage   69.20%   69.63%   +0.42%     
==========================================
  Files          16       16              
  Lines        2715     2760      +45     
  Branches      765      766       +1     
==========================================
+ Hits         1879     1922      +43     
- Misses        450      452       +2     
  Partials      386      386              
Impacted Files Coverage Δ
...lc_parameter/src/rclc_parameter/parameter_server.c 83.10% <95.55%> (+0.68%) :arrow_up:
rosterloh commented 1 year ago

If it's at all helpful I've checkout out and built this branch and it fixes the ros2cli issues for me.

JanStaschulat commented 1 year ago

@mergifyio backport rolling iron

mergify[bot] commented 1 year ago

backport rolling iron

✅ Backports have been created

* [#357 Add empty set_atomically parameter service (backport #354)](https://github.com/ros2/rclc/pull/357) has been created for branch `rolling` * [#358 Add empty set_atomically parameter service (backport #354)](https://github.com/ros2/rclc/pull/358) has been created for branch `iron`
JanStaschulat commented 1 year ago

@Acuadros95 I added a backport for rolling and iron distribution. Do you want/need this fix on Humble and Foxy distribution as well?

Acuadros95 commented 1 year ago

@JanStaschulat No, this is just needed on Iron and Rolling. Thanks!