Closed Acuadros95 closed 1 year ago
Merging #354 (72621aa) into master (2648503) will increase coverage by
0.42%
. The diff coverage is95.55%
.
@@ Coverage Diff @@
## master #354 +/- ##
==========================================
+ Coverage 69.20% 69.63% +0.42%
==========================================
Files 16 16
Lines 2715 2760 +45
Branches 765 766 +1
==========================================
+ Hits 1879 1922 +43
- Misses 450 452 +2
Partials 386 386
Impacted Files | Coverage Δ | |
---|---|---|
...lc_parameter/src/rclc_parameter/parameter_server.c | 83.10% <95.55%> (+0.68%) |
:arrow_up: |
If it's at all helpful I've checkout out and built this branch and it fixes the ros2cli issues for me.
@mergifyio backport rolling iron
backport rolling iron
@Acuadros95 I added a backport for rolling and iron distribution. Do you want/need this fix on Humble and Foxy distribution as well?
@JanStaschulat No, this is just needed on Iron and Rolling. Thanks!
New parameter client implementations check the availability of all the related services before executing a command. We were missing the
/set_parameters_atomically
, making ROS 2 Cli parameter commands fail.This PR adds a empty service implementation to fix this issue. Related: https://github.com/micro-ROS/micro-ROS-Agent/issues/195
Note: This fix shall be included on the Iron release.