ros2 / rclc

ROS Client Library for the C language.
Apache License 2.0
118 stars 42 forks source link

CI jobs on ROS2 build farm are not triggered for Iron and Rolling #366

Closed JanStaschulat closed 1 year ago

JanStaschulat commented 1 year ago

TODO:


@pablogs9 @Acuadros95 the ci pipeline on OSRF build farm is not triggered for Rolling and Iron for all of the pending pull requests. Do you have any idea what else to check?

pending pull requests:

I have also seen that you have updated the line in one of the micro-ros/setup repos: https://github.com/ros2/rclc/blob/master/.github/workflows/ci.yml#L26

Might this be the reason? Where is this documented? Could you provide a link to the documentation for the changes of v2 and v3?

Acuadros95 commented 1 year ago

Might this be the reason? Where is this documented? Could you provide a link to the documentation for the changes of v2 and v3?

v3 updates to Node16, which will be the version used on github actions. Sources:

I really hope this is not the reason for the not triggered CIs

Acuadros95 commented 1 year ago

I would say its related to the branch used, maybe something needs to be configured on the build farm side?

JanStaschulat commented 1 year ago

I updated the action/checkout version for some PR. This did not resolve the issue.

JanStaschulat commented 1 year ago

I would say its related to the branch used, maybe something needs to be configured on the build farm side?

That's a good point.

JanStaschulat commented 1 year ago

Indeed, the Iron- and Rolling- build jobs on the ROS build farm are using the master branch on rosdistro:

I need make a new bloom release for the iron and rolling distribution with changed branch names.

JanStaschulat commented 1 year ago

status:

I would do the following:

@Acuadros95 , @pablogs9 Do you agree?

JanStaschulat commented 1 year ago

Created a bloom release for Iron, however the iron branch was not updated with the bloom-release tool. I need to create another pull reqest again that changes the branch name.

PR for iron: https://github.com/ros/rosdistro/pull/37664

PR for rolling: https://github.com/ros/rosdistro/pull/37675

JanStaschulat commented 1 year ago

Created two pull requests to change the source branch name for ...:

JanStaschulat commented 1 year ago

@pablogs9 @Acuadros95 The bloom release is finished for Rolling and Iron including updated branch names. Closing this issue.