ros2 / rclc

ROS Client Library for the C language.
Apache License 2.0
118 stars 42 forks source link

fix rclc_example: memory leaking in msg.data allocation (backport #386) #387

Closed mergify[bot] closed 1 year ago

mergify[bot] commented 1 year ago

This is an automatic backport of pull request #386 done by Mergify.


Mergify commands and options
More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport ` will backport this PR on `` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com
Zard-C commented 1 year ago

https://build.ros2.org/job/Rpr__rclc__ubuntu_jammy_amd64/163/clang-tidy/new/folder.-84953004/ It seems that clang-tidy does not pass the check, due to ‘rcl_timer_init’ is deprecated: Call rcl_timer_init2 instead

codecov-commenter commented 1 year ago

Codecov Report

Merging #387 (605a475) into rolling (14c2c41) will decrease coverage by 0.20%. The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           rolling     #387      +/-   ##
===========================================
- Coverage    69.63%   69.44%   -0.20%     
===========================================
  Files           16       16              
  Lines         2760     2762       +2     
  Branches       766      766              
===========================================
- Hits          1922     1918       -4     
- Misses         452      456       +4     
- Partials       386      388       +2     
Files Changed Coverage Δ
rclc/src/rclc/timer.c 58.33% <50.00%> (-11.67%) :arrow_down:

... and 1 file with indirect coverage changes

JanStaschulat commented 1 year ago

I made DCO check pass.